Developer Francis was reportedly a little too "excited" in a code review meeting this past Tuesday, according to inside sources. Every time the swapGroupReferences() method was mentioned, Francis went on a prolonged discourse about why this method was written the way it was. Apparently it is very performant, easily unit tested, and abstracted so it can be re-used in other areas of the codebase. The team thought it was a useful helper method, but Francis thought so much more of it.
"The code is so sexy. It's CLEAN, follows SOLID, and it's easy to understand what it's doing. If you look here, it...oooh yeah. You can see the input parameters are very abstract, so you can use it however you want. And the method uses an array from the buffer pool. It knows what it wants and grabs an instance from the buffer for the exact size we need for the group. That array buffer is hydrated on app startup so we don't need to slow down at runtime by creating new instances. Here's the static init() hydration method. God just look at that method body. I can't even think straight right now," said Francis (emphasis his). At which point he left the meeting room to "cool off" and returned a few minutes later smelling like a cigarette. "Anyway, I think we're done here. Any objections or can we merge?"
When reached for comment, the HR department responded this is, "Not the first time we've heard of this happening. The last company I worked for had to create a policy to disallow code review meetings for this exact reason. These things happen with developers."
After the code was merged, QA found a fairly serious bug. The PR has been reverted, and the bug was assigned to Casey.
